Reimplemented whitelist handling

lib/rules.js

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/FileUtils.jsm");
 
 let {Prefs} = require("prefs");
 
 let RULES_VERSION = 2;
@@ skipping 77 matching lines @@
 }
 
 function addCustomRules()
 {
   for (let domain in Prefs.whitelist)
     onWhitelistEntryAdded(domain);
 }
 
 function onWhitelistEntryAdded(domain)
 {
-  let reverse = Array.prototype.slice.call(domain).reverse().join("");

[Thomas Greiner, 2012/09/26 15:59:35]

also in onWhitelistEntryAdded function

+  let reverse = domain.split("").reverse().join("");
   addSuffix(rules.domain, reverse, CUSTOM_RULE_PRIORITY);
 }
 exports.onWhitelistEntryAdded = onWhitelistEntryAdded;
 
 function onWhitelistEntryRemoved(domain)
 {
-  let reverse = Array.prototype.slice.call(domain).reverse().join("");

[Thomas Greiner, 2012/09/26 15:49:13]

It looks less confusing if you do it this way:

let reverse = domain.slice().reverse().join("");

[Wladimir Palant, 2012/09/27 14:55:06]

domain is a string - string.slice() returns another string, no reverse()
function there. But you probably meant split("").

+  let reverse = domain.split("").reverse().join("");
   removeSuffix(rules.domain, reverse, CUSTOM_RULE_PRIORITY);
 }
 exports.onWhitelistEntryRemoved = onWhitelistEntryRemoved;
 
 function addSuffix(tree, suffix, priority)
 {
   if (suffix.length == 0)
   {
     // We are at the last character, just put our priority here
     tree[""] = " " + priority;
@@ skipping 284 matching lines @@
       bestSuggestionDistance = distance;
       bestSuggestionMatched = matchedLen;
       bestSuggestionPriority = priority;
     }
   }
   if (bestSuggestion)
     return input.substr(0, input.length - bestSuggestionMatched) + bestSuggestion;
   else
     return input;
 }