ABP/Android JavaScript code

assets/js/XMLHttpRequest.jsm

 
 XMLHttpRequest = function()
 {
   this.headers = {};
   this.responseHeaders = {};
 };
 
 XMLHttpRequest.UNSENT = 0;
 XMLHttpRequest.OPEN = 1;
 XMLHttpRequest.HEADERS_RECEIVED = 2;
@@ skipping 59 matching lines @@
   },
   onreadystatechange: function(){},
   getResponseHeader: function(header)
   {
     if (this.readyState < XMLHttpRequest.LOADING)
       throw new Error("INVALID_STATE_ERR");
     else
     {
       var lcHeader = header.toLowerCase();
       var returnedHeaders = [];
       for (var rHeader in this.responseHeaders)

[Felix Dahlke, 2012/11/13 07:53:14]

You might want to make sure that you're not iterating over any prototype
properties here, like this:

for (var rHeader in this.responseHeaders)
  if (this.responseHeaders.hasOwnProperty(rHeader)
      && rHeader.toLowerCase() == lcHeader)
    returnedHeaders.push(this.responseHeaders[rHeader]);

But it does not seem likely that any prototype property would coincide with a
header field name.

[Andrey Novikov, 2012/11/13 09:44:54]

Done.

       {
-        if (rHeader.toLowerCase() == lcHeader)
+        if (this.responseHeaders.hasOwnProperty(rHeader) && rHeader.toLowerCase() == lcHeader)
           returnedHeaders.push(this.responseHeaders[rHeader]);
       }
 
       if (returnedHeaders.length)
         return returnedHeaders.join(", ");
     }
 
     return null;
   },
   getAllResponseHeaders: function(header)
@@ skipping 68 matching lines @@
   status: -1,
   notificationCallbacks: {},
   loadFlags: 0,
   INHIBIT_CACHING: 0,
   VALIDATE_ALWAYS: 0,
   QueryInterface: function()
   {
     return this;
   }
 };