Use platform-dependent metadata files to allow multiple builds from the same repository

packagerChrome.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus build tools,
 # Copyright (C) 2006-2012 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import sys, os, re, json, struct
 from StringIO import StringIO
 
-from packager import getDefaultFileName, readMetadata, getBuildVersion, getTemplate, Files
+import packager
+from packager import getDefaultFileName, getBuildVersion, getTemplate, Files
 
 defaultLocale = 'en_US'
 
+def getMetadataPath(baseDir):

[Felix Dahlke, 2013/01/25 07:49:43]

This function wasn't previously defined or imported here, so it seems to be
unused. Or am I missing something?

[Wladimir Palant, 2013/01/25 08:23:10]

You are right. I realized that geckoPackager.getMetadataPath() is actually being
required by the release automation (releaseAutomationGecko.py). So I added it
here as well, for consistency.

+  return packager.getMetadataPath(baseDir, 'chrome')
+
+def readMetadata(baseDir):
+  return packager.readMetadata(baseDir, 'chrome')
+
 def getIgnoredFiles(params):
   return set(('store.description',))
 
 def getPackageFiles(params):
   result = set(('_locales', 'icons', 'jquery-ui', 'lib', 'skin', 'ui',))
 
   if params['devenv']:
     result.add('qunit')
 
   baseDir = params['baseDir']
@@ skipping 174 matching lines @@
   def shutdown_server(server):
     time.sleep(10)
     server.shutdown()
   thread.start_new_thread(shutdown_server, (server,))
   server.serve_forever()
 
   if connections[0] == 0:
     print 'Warning: No incoming connections, extension probably not active in the browser yet'
   else:
     print 'Handled %i connection(s)' % connections[0]