Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/uninstalled.tmpl

Issue 29332615: Issue 3257 - Create uninstallation page in adblockplus.org (use GET http request) (Closed)
Patch Set: Addressed Sebastian comments Created Dec. 14, 2015, 2:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pages/uninstalled-submit.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/uninstalled.tmpl
===================================================================
rename from pages/uninstall-abp.tmpl
rename to pages/uninstalled.tmpl
--- a/pages/uninstall-abp.tmpl
+++ b/pages/uninstalled.tmpl
@@ -28,8 +28,8 @@
var paramSplit = param.split("=");
var input = document.createElement("input");
input.setAttribute("type", "hidden");
- input.setAttribute("name", paramSplit[0]);
- input.setAttribute("value", paramSplit[1]);
+ input.setAttribute("name", decodeURIComponent(paramSplit[0]));
+ input.setAttribute("value", decodeURIComponent(paramSplit[1]));
form.appendChild(input);
});
@@ -46,13 +46,19 @@
}
var reasonOtherCheckbox = document.getElementById("reason-other");
+ var reasonOther = document.getElementById("reason-other-container");
reasonOtherCheckbox.addEventListener("change", function()
{
- var textArea = document.getElementById("reason-other-input");
- if (textArea.hasAttribute("class"))
- textArea.removeAttribute("class")
- else
- textArea.setAttribute("class", "hidden");
+ reasonOther.classList.toggle("hidden")
Sebastian Noack 2015/12/14 14:51:40 Nit: Missing semicolon
saroyanm 2015/12/14 14:53:19 Ahh, sorry for that, Done.
+ }, false);
+
+ var reasonOtherInput = document.getElementById("reason-other-input");
+ var maxLength = reasonOtherInput.getAttribute("maxlength");
+ var charCounter = document.getElementById("characters-countdown");
+ charCounter.textContent = maxLength;
+ reasonOtherInput.addEventListener("keyup", function()
+ {
+ charCounter.textContent = maxLength - reasonOtherInput.value.length;
}, false);
var submitButton = document.getElementById("submit-form");
@@ -76,7 +82,7 @@
<section class="highlighted">
<h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translate("reasons-header", "Form heading")}}</h1>
- <form id="reasons-form" action="uninstall-abp-submit" method="post">
+ <form id="reasons-form" action="uninstalled-submit" method="get">
<ul id="reasons">
{%- for reasonId, stringId, value in reasons %}
<li>
@@ -91,7 +97,13 @@
<input id="reason-other" type="checkbox" name="reason" value="0v0" />
{{"Other, namely..."|translate("reason-other", "Last uninstallation reason")}}
</label>
- <textarea id="reason-other-input" class="hidden" name="reasonOther" placeholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("reason-other-placeholder", "Textarea placeholder text, appears after selecting 'Other, namely...' option")}}"></textarea>
+ <div id="reason-other-container" class="hidden">
+ <textarea id="reason-other-input" name="reasonOther" maxlength="300" placeholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("reason-other-placeholder", "Textarea placeholder text, appears after selecting 'Other, namely...' option")}}"></textarea>
+ <div>
+ {{"Characters remaining:"|translate("countdown-text", "Text of character limit counter appears after selecting 'Other, namely...' option")}}
+ <span id="characters-countdown"></span>
+ </div>
+ </div>
</li>
</ul>
<button id="submit-form">{{"Submit"|translate("submit", "Submit button text")}}</button>
« no previous file with comments | « no previous file | pages/uninstalled-submit.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld