Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29333538: Issue 3515 - Remove outdated hack ignoring sub-directories in lib/ (Closed)
Patch Set: Created Jan. 14, 2016, 5:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
===================================================================
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -18,14 +18,7 @@
defaultLocale = 'en_US'
def getIgnoredFiles(params):
- result = set(('store.description',))
-
- # Hack: ignore all lib subdirectories
- libDir = os.path.join(params['baseDir'], 'lib')
- for file in os.listdir(libDir):
- if os.path.isdir(os.path.join(libDir, file)):
- result.add(file)
- return result
+ return ['store.description']
Wladimir Palant 2016/01/14 19:28:04 This should still be a set - even with one entry,
Sebastian Noack 2016/01/14 23:28:41 Not that it matters with a single item, but done.
def getPackageFiles(params):
result = set(('_locales', 'icons', 'jquery-ui', 'lib', 'skin', 'ui', 'ext'))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld