Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29337971: Issue 3760 - Removed support for Opera builds (Closed)

Created:
March 8, 2016, 4:56 p.m. by Sebastian Noack
Modified:
March 9, 2016, 10:12 a.m.
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 3760 - Removed support for Opera builds

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated help text for -k option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M build.py View 1 7 chunks +12 lines, -12 lines 0 comments Download
M manifest.json.tmpl View 2 chunks +1 line, -12 lines 0 comments Download
M packagerSafari.py View 1 chunk +1 line, -1 line 0 comments Download
M releaseAutomation.py View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
https://codereview.adblockplus.org/29337971/diff/29337972/manifest.json.tmpl File manifest.json.tmpl (left): https://codereview.adblockplus.org/29337971/diff/29337972/manifest.json.tmpl#oldcode22 manifest.json.tmpl:22: {%- if not releaseBuild and type != "chrome" %} ...
March 8, 2016, 5:03 p.m. (2016-03-08 17:03:25 UTC) #1
kzar
https://codereview.adblockplus.org/29337971/diff/29337972/build.py File build.py (right): https://codereview.adblockplus.org/29337971/diff/29337972/build.py#newcode524 build.py:524: command.addOption('File containing private key and certificates required to sign ...
March 8, 2016, 5:45 p.m. (2016-03-08 17:45:11 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29337971/diff/29337972/build.py File build.py (right): https://codereview.adblockplus.org/29337971/diff/29337972/build.py#newcode524 build.py:524: command.addOption('File containing private key and certificates required to sign ...
March 8, 2016, 6:26 p.m. (2016-03-08 18:26:34 UTC) #3
kzar
March 8, 2016, 6:44 p.m. (2016-03-08 18:44:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld