Issue 29370801: Noissue - New module for installing docker on debian

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29370801: Noissue - New module for installing docker on debian (Closed)

Created:
Jan. 6, 2017, 2:34 p.m. by f.lopez

Modified:
Jan. 6, 2017, 4:41 p.m.

Reviewers:
f.nicolaisen

CC:
mathias

Visibility:
Public.

Description

Noissue - New module for installing docker on debian

Patch Set 2 : For comment #2 #

Patch Set 3 : Setting suitable defaults for docker package #

Patch Set 4 : Fix Fluent comment on the documentation (again) #

Patch Set 5 : Setting the defaults in a more beautiful place #

Created: Jan. 6, 2017, 3:07 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -0 lines)			Patch
	A	modules/docker/manifests/init.pp	View	1 2 3 4	1 chunk	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

f.nicolaisen

https://codereview.adblockplus.org/29370801/diff/29370802/modules/docker/manifests/init.pp File modules/docker/manifests/init.pp (right): https://codereview.adblockplus.org/29370801/diff/29370802/modules/docker/manifests/init.pp#newcode12 modules/docker/manifests/init.pp:12: # ensure => 'latest') or remove Fluentd (ensure => ...

Jan. 6, 2017, 2:37 p.m. (2017-01-06 14:37:47 UTC) #2

f.lopez

Jan. 6, 2017, 2:46 p.m. (2017-01-06 14:46:23 UTC) #3

LGTM

Expand All Messages | Collapse All Messages