Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/util/HardwareUtils.java

Issue 29385757: Issue 5005 - Always show the menu icon (Closed)
Patch Set: Created March 16, 2017, 9:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/util/HardwareUtils.java
===================================================================
--- a/mobile/android/base/util/HardwareUtils.java
+++ b/mobile/android/base/util/HardwareUtils.java
@@ -85,17 +85,19 @@ public final class HardwareUtils {
return sIsSmallTablet;
}
public static boolean isTelevision() {
return sIsTelevision;
}
public static boolean hasMenuButton() {
- return sHasMenuButton;
+ // Forcing behavior idependently of the presence of a hardware menu button
anton 2017/03/17 06:53:11 LGTM though i'd suggest to explain a bit what beha
Felix Dahlke 2017/03/27 15:46:57 I figure when looking at #5005 that becomes appare
+ // See https://issues.adblockplus.org/ticket/5005
+ return false;
}
public static int getMemSize() {
return SysInfo.getMemSize();
}
public static boolean isLowMemoryPlatform() {
final int memSize = getMemSize();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld