Issue 6173 - import options page title translations

Issue 6173 - import options page title translations

[saroyanm, 2017-12-07 14:30:09]

Tamara can you please let me know if I can give a go with current translations.

Currently the options page title is only in English.

[Sebastian Noack, 2017-12-07 14:45:30]

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
File locale/ar/desktop-options.json (left):

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
locale/ar/desktop-options.json:233: "options_page_title": {
This string no longer seems to be used. So how about simply renaming the message
IDs? That way you don't create any noise in future patches, that will sync the
translations with Crowdin, eventually.

[saroyanm, 2017-12-07 14:59:55]

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
File locale/ar/desktop-options.json (left):

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
locale/ar/desktop-options.json:233: "options_page_title": {
On 2017/12/07 14:45:29, Sebastian Noack wrote:
> This string no longer seems to be used. So how about simply renaming the
message
> IDs? That way you don't create any noise in future patches, that will sync the
> translations with Crowdin, eventually.

It is being used, it is part of actual title of the page in the sidebar
"Settings", the ID wasn't updated to reflect that better in order not to lose
existing translations.

[Sebastian Noack, 2017-12-07 15:05:59]

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
File locale/ar/desktop-options.json (left):

https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
locale/ar/desktop-options.json:233: "options_page_title": {
On 2017/12/07 14:59:55, saroyanm wrote:
> On 2017/12/07 14:45:29, Sebastian Noack wrote:
> > This string no longer seems to be used. So how about simply renaming the
> message
> > IDs? That way you don't create any noise in future patches, that will sync
the
> > translations with Crowdin, eventually.
> 
> It is being used, it is part of actual title of the page in the sidebar
> "Settings", the ID wasn't updated to reflect that better in order not to lose
> existing translations.

Well, you removed "options_page_title" from the source strings:
https://hg.adblockplus.org/adblockplusui/rev/ca194a8270c7

[kzar, 2017-12-07 15:09:13]

On 2017/12/07 15:05:59, Sebastian Noack wrote:
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> File locale/ar/desktop-options.json (left):
> 
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> locale/ar/desktop-options.json:233: "options_page_title": {
> On 2017/12/07 14:59:55, saroyanm wrote:
> > On 2017/12/07 14:45:29, Sebastian Noack wrote:
> > > This string no longer seems to be used. So how about simply renaming the
> > message
> > > IDs? That way you don't create any noise in future patches, that will sync
> the
> > > translations with Crowdin, eventually.
> > 
> > It is being used, it is part of actual title of the page in the sidebar
> > "Settings", the ID wasn't updated to reflect that better in order not to
lose
> > existing translations.
> 
> Well, you removed "options_page_title" from the source strings:
> https://hg.adblockplus.org/adblockplusui/rev/ca194a8270c7

There were two strings, with two values, used in two separate places. The bug
was that they happened to have the same name, and thus weren't translated and
didn't get populated as we expected. In that commit Manvel fixed the mistake,
notice how the string below has the same name "options_page_title" as the other
string used to.

[Sebastian Noack, 2017-12-07 15:20:30]

On 2017/12/07 15:09:13, kzar wrote:
> On 2017/12/07 15:05:59, Sebastian Noack wrote:
> >
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> > File locale/ar/desktop-options.json (left):
> > 
> >
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> > locale/ar/desktop-options.json:233: "options_page_title": {
> > On 2017/12/07 14:59:55, saroyanm wrote:
> > > On 2017/12/07 14:45:29, Sebastian Noack wrote:
> > > > This string no longer seems to be used. So how about simply renaming the
> > > message
> > > > IDs? That way you don't create any noise in future patches, that will
sync
> > the
> > > > translations with Crowdin, eventually.
> > > 
> > > It is being used, it is part of actual title of the page in the sidebar
> > > "Settings", the ID wasn't updated to reflect that better in order not to
> lose
> > > existing translations.
> > 
> > Well, you removed "options_page_title" from the source strings:
> > https://hg.adblockplus.org/adblockplusui/rev/ca194a8270c7
> 
> There were two strings, with two values, used in two separate places. The bug
> was that they happened to have the same name, and thus weren't translated and
> didn't get populated as we expected. In that commit Manvel fixed the mistake,
> notice how the string below has the same name "options_page_title" as the
other
> string used to.

Gotya. LGTM.

[tamara, 2017-12-08 12:17:28]

On 2017/12/07 15:20:30, Sebastian Noack wrote:
> On 2017/12/07 15:09:13, kzar wrote:
> > On 2017/12/07 15:05:59, Sebastian Noack wrote:
> > >
> >
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> > > File locale/ar/desktop-options.json (left):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29632580/diff/29632693/locale/ar/desktop-o...
> > > locale/ar/desktop-options.json:233: "options_page_title": {
> > > On 2017/12/07 14:59:55, saroyanm wrote:
> > > > On 2017/12/07 14:45:29, Sebastian Noack wrote:
> > > > > This string no longer seems to be used. So how about simply renaming
the
> > > > message
> > > > > IDs? That way you don't create any noise in future patches, that will
> sync
> > > the
> > > > > translations with Crowdin, eventually.
> > > > 
> > > > It is being used, it is part of actual title of the page in the sidebar
> > > > "Settings", the ID wasn't updated to reflect that better in order not to
> > lose
> > > > existing translations.
> > > 
> > > Well, you removed "options_page_title" from the source strings:
> > > https://hg.adblockplus.org/adblockplusui/rev/ca194a8270c7
> > 
> > There were two strings, with two values, used in two separate places. The
bug
> > was that they happened to have the same name, and thus weren't translated
and
> > didn't get populated as we expected. In that commit Manvel fixed the
mistake,
> > notice how the string below has the same name "options_page_title" as the
> other
> > string used to.
> 
> Gotya. LGTM.

LGTM