Issue 29720593: ABB: Noissue - Carthage bump

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29720593: ABB: Noissue - Carthage bump (Closed)

Created:
March 12, 2018, 12:32 p.m. by a.shephard

Modified:
March 14, 2018, 9:17 a.m.

Reviewers:
d108, dean

Visibility:
Public.

Description

ABB: Noissue - Carthage bump

Patch Set 1 #

Created: March 12, 2018, 12:32 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Cartfile.resolved	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

a.shephard

bumped Carthage dependency versions on Carthage.resolved file

March 12, 2018, 12:33 p.m. (2018-03-12 12:33:31 UTC) #1

dean

On 2018/03/12 12:33:31, a.shephard wrote: > bumped Carthage dependency versions on Carthage.resolved file LGTM

March 13, 2018, 10:10 a.m. (2018-03-13 10:10:39 UTC) #2

d108

On 2018/03/13 10:10:39, dean wrote: > On 2018/03/12 12:33:31, a.shephard wrote: > > bumped Carthage ...

March 14, 2018, 1:56 a.m. (2018-03-14 01:56:28 UTC) #3

a.shephard

March 14, 2018, 9:01 a.m. (2018-03-14 09:01:53 UTC) #4

On 2018/03/14 01:56:28, d108 wrote:
> On 2018/03/13 10:10:39, dean wrote:
> > On 2018/03/12 12:33:31, a.shephard wrote:
> > > bumped Carthage dependency versions on Carthage.resolved file
> > 
> > LGTM
> 
> LGTM but the dependencies should be hosted by adblockplus

Agreed. We can do this as part of a separate issue once the dependencies have
been moved (either GH or GL).

Expand All Messages | Collapse All Messages