Issue 29756571: Issue 6609: KittCore Removed CI values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29756571: Issue 6609: KittCore Removed CI values (Closed)

Created:
April 19, 2018, 9:13 a.m. by a.shephard

Modified:
April 24, 2018, 12:21 p.m.

Reviewers:
d108, dean

Visibility:
Public.

Patch Set 2 : Issue 6609 - Remove CI Values from KittCore, added BUILD_NUMBER to Build Settings, created issue nu… #

Created: April 23, 2018, 8:40 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	Info-Framework.plist	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Info-ResourceBundle.plist	View		1 chunk	+1 line, -1 line	0 comments	Download
M	KittCore.xcodeproj/project.pbxproj	View	1	6 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

a.shephard

I've removed the CORE_BUILD_NUMBER from KittCore too and will add this logic again once we've ...

April 19, 2018, 9:13 a.m. (2018-04-19 09:13:53 UTC) #1

d108

On 2018/04/19 09:13:53, a.shephard wrote: > I've removed the CORE_BUILD_NUMBER from KittCore too and will ...

April 21, 2018, 4:05 a.m. (2018-04-21 04:05:59 UTC) #3

d108

https://codereview.adblockplus.org/29756571/diff/29756572/KittCore.xcodeproj/project.pbxproj File KittCore.xcodeproj/project.pbxproj (left): https://codereview.adblockplus.org/29756571/diff/29756572/KittCore.xcodeproj/project.pbxproj#oldcode1930 KittCore.xcodeproj/project.pbxproj:1930: CORE_BUILD_NUMBER = 0; Seems like this symbol should also ...

April 21, 2018, 4:06 a.m. (2018-04-21 04:06:15 UTC) #4

a.shephard

Added BUILD_NUMBER to Build Settings, made an issue number for this also. Same as ABB, ...

April 23, 2018, 8:42 a.m. (2018-04-23 08:42:15 UTC) #5

d108

On 2018/04/23 08:42:15, a.shephard wrote: > Added BUILD_NUMBER to Build Settings, made an issue number ...

April 23, 2018, 10 p.m. (2018-04-23 22:00:30 UTC) #6

dean

April 23, 2018, 10:30 p.m. (2018-04-23 22:30:44 UTC) #7

On 2018/04/23 22:00:30, d108 wrote:
> On 2018/04/23 08:42:15, a.shephard wrote:
> > Added BUILD_NUMBER to Build Settings, made an issue number for this also.
Same
> > as ABB, will limit it to removal of CI and will make another issue number
for
> > adding CI.
> 
> LGTM

LGTM

Expand All Messages | Collapse All Messages