Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/iniParser.js

Issue 29870577: Issue 6916 - Encapsulate filter subscriptions (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Add JSDoc for addSubscription and removeSubscription Created Sept. 1, 2018, 2:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/filterStorage.js ('k') | test/filterListener.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/iniParser.js
===================================================================
--- a/lib/iniParser.js
+++ b/lib/iniParser.js
@@ -105,17 +105,17 @@
{
let currentSubscription = this.subscriptions[
this.subscriptions.length - 1
];
for (let text of this._curObj)
{
let filter = Filter.fromText(text);
currentSubscription.filters.push(filter);
- filter.subscriptions.add(currentSubscription);
+ filter.addSubscription(currentSubscription);
}
}
break;
}
}
if (line === null)
return;
« no previous file with comments | « lib/filterStorage.js ('k') | test/filterListener.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld