Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.postload.js

Issue 4916569079545856: Noissue - Declare clickHideFilters and selectorList properly (Closed)
Patch Set: Created Jan. 16, 2015, 8:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.postload.js
diff --git a/include.postload.js b/include.postload.js
index 41187950dec2308c957ae6fd336fdc2c24fadce4..30f02b011848af3a9e5cf05cdaf80d84940f5a69 100644
--- a/include.postload.js
+++ b/include.postload.js
@@ -19,7 +19,6 @@
var clickHide_activated = false;
var clickHide_filters = null;
var currentElement = null;
-var clickHideFilters = null;
var highlightedElementsSelector = null;
var clickHideFiltersDialog = null;
var lastRightClickEvent = null;
@@ -395,7 +394,6 @@ function clickHide_deactivate(keepOverlays)
unhighlightElements();
unhighlightElement(currentElement);
currentElement = null;
- clickHideFilters = null;
}
unhighlightElements();
@@ -474,8 +472,8 @@ function clickHide_mouseClick(e)
if (currentElement.classList.contains("__adblockplus__overlay"))
elt = currentElement.prisoner;
- clickHideFilters = new Array();
- selectorList = new Array();
+ var clickHideFilters = new Array();
Sebastian Noack 2015/01/16 20:59:15 While changing those lines, mind using array liter
kzar 2015/01/16 21:04:27 Done.
+ var selectorList = new Array();
var addSelector = function(selector)
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld