src/plugin/Plugin.cpp - Issue 5994126579335168: Noissue - Remove a dead inheritance and some dead code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/Plugin.cpp

Issue 5994126579335168: Noissue - Remove a dead inheritance and some dead code (Closed)

Patch Set: Created Feb. 18, 2015, 7:06 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/plugin/Plugin.cpp

===================================================================

--- a/src/plugin/Plugin.cpp

+++ b/src/plugin/Plugin.cpp

@@ -132,9 +132,9 @@

// Post async plugin error

CPluginError pluginError;

- while (CPluginClientBase::PopFirstPluginError(pluginError))

+ while (LogQueue::PopFirstPluginError(pluginError))

{

- CPluginClientBase::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());

+ LogQueue::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());

}

« no previous file with comments | « src/plugin/Config.h ('k') | src/plugin/PluginClientBase.h » ('j') | src/plugin/PluginTabBase.cpp » ('J')