Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClientBase.h

Issue 5994126579335168: Noissue - Remove a dead inheritance and some dead code (Closed)
Patch Set: Created Feb. 18, 2015, 7:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginClientBase.h
===================================================================
--- a/src/plugin/PluginClientBase.h
+++ b/src/plugin/PluginClientBase.h
@@ -18,7 +18,8 @@
#ifndef _PLUGIN_CLIENT_BASE_H_
#define _PLUGIN_CLIENT_BASE_H_
-class CPluginClientFactory;
+#include <vector>
+#include "ATL_Deprecate.h"
class CPluginError
{
@@ -56,31 +57,14 @@
};
-class CPluginClientBase
+class LogQueue
{
- friend class CPluginClientFactory;
-
private:
-
static std::vector<CPluginError> s_pluginErrors;
-
- static bool s_isErrorLogging;
-
-protected:
-
- // Protected constructor used by the singleton pattern
- CPluginClientBase();
-
- static CComAutoCriticalSection s_criticalSectionLocal;
+ static CComAutoCriticalSection s_criticalSectionQueue;
public:
-
- ~CPluginClientBase();
-
- static void SetLocalization();
-
static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwThreadId=0);
-
static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, const CString& errorDescription);
static bool PopFirstPluginError(CPluginError& pluginError);
};

Powered by Google App Engine
This is Rietveld