Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29370780: Issue 4234 - New role for forum servers (Closed)

Created:
Jan. 6, 2017, 10:45 a.m. by f.nicolaisen
Modified:
Jan. 6, 2017, 4:41 p.m.
Reviewers:
f.lopez
CC:
mathias
Visibility:
Public.

Description

Issue 4234 - New role for forum servers This role is based on the previously committed discourse_docker module. Site-specific settings should be provided on a host-specific basis inside the private hiera folder.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A hiera/roles/forumserver.yaml View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 5
f.nicolaisen
Jan. 6, 2017, 10:45 a.m. (2017-01-06 10:45:03 UTC) #1
f.nicolaisen
Depends on https://codereview.adblockplus.org/29370691/ being merged first!
Jan. 6, 2017, 10:46 a.m. (2017-01-06 10:46:25 UTC) #2
f.lopez
https://codereview.adblockplus.org/29370780/diff/29370781/hiera/roles/forumserver.yaml File hiera/roles/forumserver.yaml (right): https://codereview.adblockplus.org/29370780/diff/29370781/hiera/roles/forumserver.yaml#newcode3 hiera/roles/forumserver.yaml:3: docker: we will need something like package: 'latest' provider: ...
Jan. 6, 2017, 2:40 p.m. (2017-01-06 14:40:27 UTC) #3
f.nicolaisen
https://codereview.adblockplus.org/29370780/diff/29370781/hiera/roles/forumserver.yaml File hiera/roles/forumserver.yaml (right): https://codereview.adblockplus.org/29370780/diff/29370781/hiera/roles/forumserver.yaml#newcode3 hiera/roles/forumserver.yaml:3: docker: On 2017/01/06 14:40:27, f.lopez wrote: > we will ...
Jan. 6, 2017, 2:55 p.m. (2017-01-06 14:55:59 UTC) #4
f.lopez
Jan. 6, 2017, 3:05 p.m. (2017-01-06 15:05:09 UTC) #5
LGTM, this goes after discourse_docker module

Powered by Google App Engine
This is Rietveld