Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/websocket.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed more feedback. Added README. Created June 7, 2018, 10:20 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/filters/websocket.tmpl
===================================================================
--- a/pages/filters/websocket.tmpl
+++ b/pages/filters/websocket.tmpl
@@ -1,4 +1,4 @@
-title = $websocket - ABP Test Pages
+title = $websocket
template = testcase
{% set testcase_moreinfo = [
@@ -7,12 +7,6 @@
<script>
-function pagelog(message) {
- var log = document.getElementById("testcase-fo-websocket");
- log.innerText = log.innerText + message + "\n";
- console.log(message);
-}
-
function ws_open(evt) {
pagelog("Connected");
websocket.send("Test message was echoed back");
@@ -48,13 +42,14 @@
<section class="site-panel">
<h2>$websocket</h2>
<p>Check that usage of the $websocket filter option works as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the websocket connection should be blocked and not echo back the test message.</p>
</section>
<section class="site-panel">
<h2>Test case</h2>
<div class="testcase-container">
- <div class="testcase-row"><h3>WebSocket Request</h3><div id="testcase-fo-websocket"></div></div>
+ <div class="testcase-row"><h3>WebSocket Request</h3><div id="testcase-output"></div></div>
</div>
<h3>Filters</h3>
- $websocket,domain=testpages.adblockplus.org
+ <pre>$websocket,domain=testpages.adblockplus.org</pre>
</section>
« README.md ('K') | « pages/filters/webrtc.tmpl ('k') | pages/filters/xmlhttprequest.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld